Feature/epub module refactoring #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit eliminates the remaining usages of JSON data structures that were endemic to readium-js. Currently, only data structures accepted by readium-shared-js are produced and used.
The recursive approach has been using up call stack. Modern browsers can suffer from call stack limits as low as 20k frames - see: http://stackoverflow.com/a/7828803 This would cause problems for publications containing more than about 20k spine items, which isn't quite outside the domain of possibility.
bormind
added a commit
that referenced
this pull request
Jun 1, 2014
Feature/epub module refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request contains the current progress on epub module refactoring.
Changes in this request eliminate the remaining usages of data structures endemic to readium-js. Now, only data structures accepted by readium-shared-js are produced and used.
Also, in a separate commit, the fix for
rendition_spreadproperty propagation is included.The pull request should merge cleanly onto develop.