-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the audio navigator issue for one-chapter books #292
Fix the audio navigator issue for one-chapter books #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to tackle this issue! And sorry about the delay, I was in holidays.
I made some changes, could you take a look and let me know if that's fine with you?
- If a
locator
doesn't have any locations (not evenprogression = 0
), it would not navigate to the start of the target resource. - Only notify
didJumpTo:
if the jump was not interrupted (finished = true
)
Also there are build issues in the CI, I'll take a look.
ca3330f
to
03d757c
Compare
Hi Michel, Thank you for your changes and sorry for the long delay, I was on vacation 🏝️. I have checked when the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @grighakobian!
It's not possible to navigate to the first chapter when an audio book has only one chapter, this small PR will fix for that issue.
Hot to reproduce:
Expected result: The audio navigator should start playing from beginning.
Actual result: The player remains on current position, nothing get changed.