Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the audio navigator issue for one-chapter books #292

Merged

Conversation

grighakobian
Copy link
Contributor

It's not possible to navigate to the first chapter when an audio book has only one chapter, this small PR will fix for that issue.

Hot to reproduce:

  1. Open an audiobook which has only one chapter
  2. Play the audio book
  3. Try to navigate to the first chapter

Expected result: The audio navigator should start playing from beginning.

Actual result: The player remains on current position, nothing get changed.

@grighakobian grighakobian changed the base branch from main to develop April 26, 2023 11:05
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to tackle this issue! And sorry about the delay, I was in holidays.

I made some changes, could you take a look and let me know if that's fine with you?

  • If a locator doesn't have any locations (not even progression = 0), it would not navigate to the start of the target resource.
  • Only notify didJumpTo: if the jump was not interrupted (finished = true)

Also there are build issues in the CI, I'll take a look.

@mickael-menu mickael-menu temporarily deployed to LCP May 19, 2023 10:30 — with GitHub Actions Inactive
@mickael-menu mickael-menu temporarily deployed to LCP May 19, 2023 10:30 — with GitHub Actions Inactive
@grighakobian
Copy link
Contributor Author

grighakobian commented May 31, 2023

Thanks for taking the time to tackle this issue! And sorry about the delay, I was in holidays.

I made some changes, could you take a look and let me know if that's fine with you?

  • If a locator doesn't have any locations (not even progression = 0), it would not navigate to the start of the target resource.
  • Only notify didJumpTo: if the jump was not interrupted (finished = true)

Also there are build issues in the CI, I'll take a look.

Hi Michel,

Thank you for your changes and sorry for the long delay, I was on vacation 🏝️.

I have checked when the progression is nil the navigator jumps to the start of the target.

@mickael-menu mickael-menu temporarily deployed to LCP June 8, 2023 16:22 — with GitHub Actions Inactive
@mickael-menu mickael-menu temporarily deployed to LCP June 8, 2023 16:26 — with GitHub Actions Inactive
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @grighakobian!

@mickael-menu mickael-menu merged commit 36ba38a into readium:develop Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants