Improve URL equality #453
Merged
Improve URL equality #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
added a commit
to demarque/readium-swift-toolkit
that referenced
this pull request
Jun 11, 2024
mickael-menu
added a commit
that referenced
this pull request
Jun 12, 2024
This reverts commit 91bc159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of comparing URL to their string representation, compare their components with different rules:
The reason for this change is that some EPUBs encode unreserved characters which breaks locating a Link from an HREF.
For example both of these are valid relative URLs which point to the same resource:
Text/Ces_choses_qu'on_laisse.xhtmlText/Ces_choses_qu%27on_laisse.xhtml