fix: allow to pass non-undefined values(#149)

readmeio · Oct 18, 2018 · b70fb90 · b70fb90
1 parent d2df77e
commit b70fb90
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 2 deletions.
diff --git a/packages/api-explorer/__tests__/lib/oas-to-har.test.js b/packages/api-explorer/__tests__/lib/oas-to-har.test.js
@@ -190,6 +190,26 @@ describe('path values', () => {
       ).log.entries[0].request.url,
     ).toBe('https://example.com/param-path/456');
   });
+
+  test('should add non-undefined values to the url', () => {
+    expect(
+      oasToHar(
+        {},
+        {
+          path: '/param-path/{id}',
+          method: 'get',
+          parameters: [
+            {
+              name: 'id',
+              in: 'path',
+              required: true,
+            },
+          ],
+        },
+        { path: { id: 0 } },
+      ).log.entries[0].request.url,
+    ).toBe('https://example.com/param-path/0');
+  });
 });
 
 describe('query values', () => {

diff --git a/packages/api-explorer/__tests__/lib/parameters-to-json-schema.test.js b/packages/api-explorer/__tests__/lib/parameters-to-json-schema.test.js
@@ -351,3 +351,20 @@ test('it should pull out schemas from `components/requestBodies`', () => {
 });
 
 test.skip('it should make things required correctly', () => {});
+
+test('it should pass false value as default parameter', () => {
+  expect(
+    parametersToJsonSchema({
+      parameters: [
+        {
+          in: 'query',
+          name: 'check',
+          schema: {
+            type: 'boolean',
+            default: false,
+          },
+        },
+      ],
+    })[0].schema.properties.check,
+  ).toEqual({ default: false, type: 'boolean' });
+});
diff --git a/packages/api-explorer/src/lib/oas-to-har.js b/packages/api-explorer/src/lib/oas-to-har.js
@@ -17,7 +17,7 @@ const format = {
 };
 
 function formatter(values, param, type, onlyIfExists) {
-  if (values[type][param.name]) {
+  if (typeof values[type][param.name] !== 'undefined') {
     return format.value(values[type][param.name]);
   }
   if (onlyIfExists && !param.required) {

diff --git a/packages/api-explorer/src/lib/parameters-to-json-schema.js b/packages/api-explorer/src/lib/parameters-to-json-schema.js
@@ -43,7 +43,7 @@ function getOtherParams(pathOperation) {
           schema.items = current.schema.items;
         }
 
-        if (current.schema.default) schema.default = current.schema.default;
+        if (typeof current.schema.default !== 'undefined') schema.default = current.schema.default;
         if (current.schema.enum) schema.enum = current.schema.enum;
         if (current.schema.type) schema.type = current.schema.type;
         if (current.schema.format) schema.format = current.schema.format;