This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix: upgrading snippet dependencies to fix various issues #1253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This fixes a host of issues with snippet generation across a couple languages and targets:
fetch
snippets returnresponse.json()
. update javascript fetch request to match node-fetch Kong/httpsnippet#210qs
isn't supported by Node'snode-fetch
, resulting in query params not being sent. fix: not sending form urlencoded properly in JS fetch snippets httpsnippet#43fetch
snippets onapplication/x-www-url-formencoded
were being sent as objects instead of strings, resulting in[Object object]
being sent to the API. fix: not sending form urlencoded properly in JS fetch snippets httpsnippet#43node-simple
when bothbody
andmetadata
parameters are present. feat: cleaner snippets when body and metadata are present api#269🧬 Testing
Provide as much information as you can on how to test what you've done.