fix: not sending form urlencoded properly in JS fetch snippets #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbwyme Heads up that this'll fix the issue you're seeing on your Track Event docs. This should hopefully make it out to production later this week or next Tuesday. |
4 tasks
|
Woohoo, thanks!
…On Tuesday, April 20, 2021, Jon Ursenbach ***@***.***> wrote:
Merged #43 <#43> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEH6UU7L6OJZZXEVENIICDTJXTKJANCNFSM43JBHFEQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS
fetchbody needs to be a string, and we were sending objects onx-www-url-formencodedrequests. This fixes that by wrapping those objects innew URLSearchParams.