Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

chore(deps): upgrading oas to v6 #1041

Merged
merged 10 commits into from
Nov 24, 2020
Merged

chore(deps): upgrading oas to v6 #1041

merged 10 commits into from
Nov 24, 2020

Conversation

erunion
Copy link
Member

@erunion erunion commented Nov 10, 2020

🧰 What's being changed?

Upgrades us to v6 of the oas library which included some breaking changes for how data was stored within the Operation class that oas/tooling exposes.

📖 Release Notes

6.1.0 (2020-11-12)

6.0.0 (2020-11-10)

BREAKING CHANGE

If you are using oas/tooling the internal storage within the Operation class has been changed to no longer override the internal scope of itself. Operation data within that class is now stored within a schema property.

And if you aren't using oas/tooling, carry on!

@erunion erunion added the scope:dependency Pull requests that update a dependency file label Nov 10, 2020
@erunion erunion requested a review from darrenyong November 13, 2020 23:50
@@ -263,10 +263,11 @@ class Doc extends React.Component {

return (
operation &&
operation.responses && (
operation.schema &&
operation.schema.responses && (
Copy link
Member Author

@erunion erunion Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a hasResponses method into oas but since responses are required to be present to be a valid OAS definition I don't think it makes sense to add to account for legacy specs in our DB that might not be valid.

@erunion erunion requested a review from Dashron November 23, 2020 17:24
@erunion erunion merged commit cf74e31 into next Nov 24, 2020
@erunion erunion deleted the chore/upgrade-oas branch November 24, 2020 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope:dependency Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant