This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix(ui components): remove a stylesheet import that's now redundant #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was broken in the demo app, this appears to do the trick!
rafegoldberg
approved these changes
Feb 1, 2021
| @@ -10,7 +10,6 @@ const Oas = require('oas/tooling'); | |||
| const { getPath, matchesMimeType } = require('oas/tooling/utils'); | |||
|
|
|||
| const { TutorialTile } = require('@readme/ui/.bundles/es/ui/compositions'); | |||
| require('@readme/ui/.bundles/umd/main.css'); | |||
There was a problem hiding this comment.
This is definitely in keeping with the other CSS optimizations we've been making! But it'll be difficult to test until we roll an integration, and I know we've had some issue with cross-repo style application before.
|
Looks good on the CI app: https://readme-api-e-fix-remove-qbdqgq.herokuapp.com/ |
erunion
approved these changes
Feb 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
Now that we've migrated our full component library to the ReadMe repo, we need to remove a stylesheet import from the API Explorer repo since it's being applied twice. See https://github.com/readmeio/readme/pull/3552 for more info!
I verified that this doesn't break any of the styling in the demo app because of
bundle-hub2.css.This also does a bit of recipes-specific housekeeping:
🧬 Testing
Verify that the "Enable recipes" toggle in the demo app is working, and that none of the styling appears to be broken.