Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

feat: start exposing pattern attributes in schemas #1181

Merged
merged 1 commit into from
Feb 16, 2021
Merged

feat: start exposing pattern attributes in schemas #1181

merged 1 commit into from
Feb 16, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Feb 11, 2021 •
edited
Loading

☁️   CI App

🧰 What's being changed?

  • If there is a pattern attribute in a schema, we'll now add that pattern into the input element for that parameter.

🧬 Testing

See the types.json example and the accompanying unit test.

@erunion erunion added the type:enhancement A potential new feature to be added, or an improvement we could make label Feb 11, 2021
@erunion erunion temporarily deployed to readme-api-e-feat-expos-em9yzc February 11, 2021 00:11 Inactive
Dashron
Dashron approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@Dashron Dashron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple enough

@erunion erunion merged commit e83bbf3 into next Feb 16, 2021
@erunion erunion deleted the feat/expose-patterns branch February 16, 2021 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dashron Dashron Dashron approved these changes

@darrenyong darrenyong Awaiting requested review from darrenyong

Assignees
No one assigned
Labels
type:enhancement A potential new feature to be added, or an improvement we could make
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @Dashron