Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

chore(deps): bump ws from 7.4.4 to 7.4.6 in /packages/oas-extensions #1303

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 28, 2021

Bumps ws from 7.4.4 to 7.4.6.

Release notes

Sourced from ws's releases.

7.4.6

Bug fixes

  • Fixed a ReDoS vulnerability (00c425ec).

A specially crafted value of the Sec-Websocket-Protocol header could be used to significantly slow down a ws server.

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();
value.trim().split(/ *, */);
const end = process.hrtime.bigint();
console.log('length = %d, time = %f ns', length, end - start);
}

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

7.4.5

Bug fixes

  • UTF-8 validation is now done even if utf-8-validate is not installed (23ba6b29).
  • Fixed an edge case where websocket.close() and websocket.terminate() did not close the connection (67e25ff5).
Commits
  • f5297f7 [dist] 7.4.6
  • 00c425e [security] Fix ReDoS vulnerability
  • 990306d [lint] Fix prettier error
  • 32e3a84 [security] Remove reference to Node Security Project
  • 8c914d1 [minor] Fix nits
  • fc7e27d [ci] Test on node 16
  • 587c201 [ci] Do not test on node 15
  • f672710 [dist] 7.4.5
  • 67e25ff [fix] Fix case where abortHandshake() does not close the connection
  • 23ba6b2 [fix] Make UTF-8 validation work even if utf-8-validate is not installed
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added javascript Pull requests that update Javascript code scope:dependency Pull requests that update a dependency file labels May 28, 2021
@erunion erunion temporarily deployed to explorer-pr-1303 May 28, 2021 20:39 Inactive
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/packages/oas-extensions/ws-7.4.6 branch from 2e07bc2 to 1a88c59 Compare June 7, 2021 23:06
@erunion erunion temporarily deployed to explorer-pr-1303 June 7, 2021 23:06 Inactive
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/packages/oas-extensions/ws-7.4.6 branch from 1a88c59 to 5815f0c Compare June 8, 2021 00:28
@erunion erunion temporarily deployed to explorer-pr-1303 June 8, 2021 00:28 Inactive
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/packages/oas-extensions/ws-7.4.6 branch from 5815f0c to 49b084f Compare June 8, 2021 14:50
@erunion erunion requested a deployment to explorer-pr-1303 June 8, 2021 14:50 Abandoned
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/packages/oas-extensions/ws-7.4.6 branch from 49b084f to a0cf2b9 Compare June 8, 2021 14:51
@erunion erunion requested a deployment to explorer-pr-1303 June 8, 2021 14:51 Abandoned
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/packages/oas-extensions/ws-7.4.6 branch from a0cf2b9 to 00f2bf2 Compare June 8, 2021 14:51
@erunion erunion temporarily deployed to explorer-pr-1303 June 8, 2021 14:51 Inactive
@erunion erunion merged commit 45295b6 into main Jun 8, 2021
@erunion erunion deleted the dependabot/npm_and_yarn/packages/oas-extensions/ws-7.4.6 branch June 8, 2021 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript Pull requests that update Javascript code scope:dependency Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant