This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
feat: support multiple response types #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
erunion
suggested changes
Jul 3, 2019
| return ( | ||
| <div> | ||
| <select | ||
| style={{ backgroundColor: '#3d434a' }} |
There was a problem hiding this comment.
It would probably be best if this were a class name instead. Can you add a class for this into example/bundle-hub2.css? I'll make sure we do the same to our production CSS.
There was a problem hiding this comment.
Thanks, I've added this
0xVolodya
force-pushed
the
feat/suppoprt-multiple-response-types
branch
from
2b36ef6 to
87fbe42
Compare
0xVolodya
force-pushed
the
feat/suppoprt-multiple-response-types
branch
from
87fbe42 to
c2f9f48
Compare
erunion
approved these changes
Jul 8, 2019
erunion
added
the
type:enhancement
kanadgupta
approved these changes
Jul 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #198
@domharrington this is ready. Can you check it when you available
https://github.com/readmeio/api-explorer/pull/208/files#diff-e7f8868abb312f633724097c3a090b40R61
I fixed a broken/wrong test here which came from the master