This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
🐛 we want to run babel through all of the js files to check for IE compatibility #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested with IE11. It works! @erunion I hear you're going to be taking over this repo and its deployment processes. How do you want me to notify you when something is ready to be merged and shipped? I could tag as |
erunion
approved these changes
Jun 24, 2019
|
@dok Feel free to just @, or formally assign the PR to, me whenever you're ready. |
kanadgupta
reviewed
Jun 26, 2019
erunion
changed the title
|
@dok Can you revert the |
This reverts commit b14bde3.
|
@erunion reverted |
erunion
approved these changes
Jul 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is related to the ticket regarding
.startsWith.The fix is essentially to remove the babel exclusion for js files; This is allow babel to catch any files with compatibility issues with older browsers.