This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Redesigning the error and loading states in the reference demo #226
+332
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
the
type:enhancement
erunion
force-pushed
the
enhancement/preview-loading-design-tweaks
branch
from
3e1d267 to
dfdfe7d
Compare
erunion
commented
Jul 2, 2019
kanadgupta
approved these changes
Jul 8, 2019
mjcuva
suggested changes
Jul 16, 2019
|
@mjcuva This is ready for review again! |
rafegoldberg
approved these changes
Jul 18, 2019
|
If there is a validation error , can we move it inside the "Couldn't be loaded" section and change the copy to be "Invalid API Specification" with the error beneath it and a link to the validation report? Similar to this (but we can leave the same design we currently have): We shouldn't ever show the "Fetching Swagger/OAS file/Converting Swagger file to OAS 3 stuff" |
|
@mjcuva @rafegoldberg This is ready for review again. I've revised the error states on the preview site to no longer show our debugging "status" text (while retaining it on the demo site since that's more for Explorer development). Preview siteUnable to parse a spec
Unable to fetch a spec
Demo siteUnable to parse a spec
Unable to fetch a spec
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a few minor redesigns to our https://preview.readme.io/reference/ page and introduces:
Loading state
Better error handling
Old:
Refreshed:
