This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Adding support for $ref pointers to additionalProperties #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
the
type:enhancement
rafegoldberg
changed the title
|
Another good view of the change on a spec that a customer is running in production: Before
After
|
rafegoldberg
approved these changes
Jul 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates a branch on our existing react-jsonschema-form fork (now moved to our @readmeio org), to add support for
$refpointers onadditionalPropertiesentries in data models.Previously, if there was no
typedetected withinadditionalProperties, react-jsonschema-form would attempt to guess the type of the object as astring. Now, if a$refpointer is present, it will be loaded as expected.See readmeio/react-jsonschema-form#1 for the full changeset of that fix and readmeio/react-jsonschema-form#2 for the full changeset of what we're running in this (temporary) react-jsonschema-form fork.
Before
After