Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Configure Heroku review apps pipeline. #513

Merged
merged 4 commits into from
Mar 9, 2020
Merged

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Mar 9, 2020

🧐 API Explorer Review App

Configure a Heroku review apps pipeline for the API Explorer.

@rafegoldberg rafegoldberg temporarily deployed to api-explorer-enhancemen-luoyf4 March 9, 2020 23:03 Inactive
@rafegoldberg rafegoldberg temporarily deployed to api-explorer-enhancemen-gpkzvk March 9, 2020 23:09 Inactive
@rafegoldberg rafegoldberg temporarily deployed to api-explorer-enhancemen-thtf9h March 9, 2020 23:12 Inactive
@rafegoldberg rafegoldberg temporarily deployed to api-explorer-enhancemen-thtf9h March 9, 2020 23:37 Inactive
@rafegoldberg rafegoldberg marked this pull request as ready for review March 9, 2020 23:46
@rafegoldberg rafegoldberg requested a review from erunion March 9, 2020 23:46
@erunion
Copy link
Member

erunion commented Mar 9, 2020

Damn this is rad. Is it possible at all to get the PR app to show up in the checks list on the PR?

Screen Shot 2020-03-09 at 4 49 17 PM

RJSF has this set up with Netlify and it's really nice having a link to the app there:

Screen Shot 2020-03-09 at 4 50 14 PM

@erunion
Copy link
Member

erunion commented Mar 9, 2020

Ah I just noticed that it shows up in the activity feed:

Screen Shot 2020-03-09 at 4 53 40 PM

Maybe that's good enough.

@rafegoldberg
Copy link
Contributor Author

@erunion yeah, that was my final call in the case of the UI as well... it's not perfect, but it definitely does the trick for such minimal effort!

@rafegoldberg rafegoldberg merged commit 5907499 into master Mar 9, 2020
@rafegoldberg rafegoldberg deleted the enhancement/review-apps branch March 9, 2020 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants