This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
feat: add support for syntax highlighting more languages #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
the
type:enhancement
Can be used to retrieve a "canonical" name for a given language.
erunion
commented
Jun 3, 2020
|
Once this is out we can replace the Language Support docs on the RDMD site directly with the language support docs in |
erunion
commented
Jun 3, 2020
| aliases: { | ||
| powershell: 'PowerShell', | ||
| ps1: 'PowerShell', |
There was a problem hiding this comment.
erunion
commented
Jun 3, 2020
| @@ -0,0 +1,60 @@ | |||
| const modeAliases = { | |||
There was a problem hiding this comment.
It might be kind of tedious to maintain this list along with uppercase.js instead of just a single supportedLanguages file, but also I think the object management, and cycles, that'll need to be done to make a single datastore work for both of these usecases (canonical and uppercase) outweighs just loading another 60 line JS file.
There was a problem hiding this comment.
Yeah the manual maintenance is a bit of a pain, but I agree: worth it compared to the alternative!
rafegoldberg
approved these changes
Jun 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
Adds support to syntax highlight the following languages:
Languages from https://github.com/readmeio/api-explorer/issues/726 that I'm opting to not implement right now because their popularity is limited:
I've also slightly refactored the
Codecomponent in@readme/markdownto no longer maintain a separate syntax highlighting language mapping object, and instead to pull that data from the syntax highlighter itself via a newcanonicallibrary within it. This library takes in a language name and returns a canonical version of it. For example, supplyingjswill returnjavascript,cppwill returncplusplus,sasstocss, etc. This should make adding support for new languages less tedious.Resolves https://github.com/readmeio/api-explorer/issues/726.
🗳 Checklist