Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

fix(rdmd): don't set scrollTop if el is undefined #793

Merged
merged 1 commit into from
Jun 12, 2020
Merged

fix(rdmd): don't set scrollTop if el is undefined #793

merged 1 commit into from
Jun 12, 2020

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Jun 12, 2020 •
edited
Loading

🧰 Changes

This fixes a Sentry issue with the RDMD lightbox. (🎟)

  • add a conditional to check the current ref element exists before setting the scroll height of the lightbox.

@rafegoldberg rafegoldberg added the type:bug Something isn't working label Jun 12, 2020
erunion
erunion approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well shit that was easy

@rafegoldberg rafegoldberg merged commit fc804bd into master Jun 12, 2020
@rafegoldberg rafegoldberg deleted the fix/rdmd/scrollHeight-undefined branch June 12, 2020 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erunion erunion erunion approved these changes

@domharrington domharrington Awaiting requested review from domharrington

Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafegoldberg @erunion