This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
feat: adding support for cookies to oas-to-har #794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This adds general support for cookie parameters into the explorer and our
oas-to-har
library.Adding this because it's a deficiency of our OpenAPI support, and also the new
api
should support it and that usesoas-to-har
for the bulk of its processing. If you click on "Node (simple)" in the demo site you'll see that it currently doesn't support cookies (see readmeio/api#38).🧪 Testing
I've added a grip of tests for cookies into the
oas-to-har
suite, all of which are identical to our tests for query string params. To see this in action, load up the demo site and check out the newcookies
example:🗳 Checklist