Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

feat: adding support for cookies to oas-to-har #794

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Conversation

erunion
Copy link
Member

@erunion erunion commented Jun 16, 2020

🧰 What's being changed?

This adds general support for cookie parameters into the explorer and our oas-to-har library.

Adding this because it's a deficiency of our OpenAPI support, and also the new api should support it and that uses oas-to-har for the bulk of its processing. If you click on "Node (simple)" in the demo site you'll see that it currently doesn't support cookies (see readmeio/api#38).

🧪 Testing

I've added a grip of tests for cookies into the oas-to-har suite, all of which are identical to our tests for query string params. To see this in action, load up the demo site and check out the new cookies example:

Screen Shot 2020-06-16 at 5 03 04 PM

🗳 Checklist

💡 If answering yes to any of the following, include additional info, before/after links, screenshots, etc. where appropriate!

  • 🆕 I'm adding something new!
  • 🐛 I'm fixing a bug!
  • 📸 I've made some changes to the UI!

@erunion erunion added the type:enhancement A potential new feature to be added, or an improvement we could make label Jun 17, 2020
@erunion erunion marked this pull request as ready for review June 17, 2020 00:01
Copy link
Contributor

@rafegoldberg rafegoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through this last night. Looks good to me.

@erunion erunion merged commit 37b020d into master Jun 17, 2020
@erunion erunion deleted the feat/support-cookies branch June 17, 2020 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement A potential new feature to be added, or an improvement we could make
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants