Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

enhancement(rdmd): more compat mode features! #820

Merged
merged 5 commits into from
Jul 2, 2020

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Jul 1, 2020

🧰 Changes

This PR rounds out the compatibility mode functionality and closes #668. Turning on compat mode is meant to mimic our old markdown processor's behavior, so it should:

🧪 Testing

ReadMe integration to come.

@rafegoldberg rafegoldberg requested a review from erunion July 2, 2020 02:05
@rafegoldberg rafegoldberg added area:markdown type:enhancement A potential new feature to be added, or an improvement we could make labels Jul 2, 2020
@rafegoldberg rafegoldberg changed the title chore(rdmd): more compat mode features enhancement(rdmd): more compat mode features! Jul 2, 2020
@rafegoldberg rafegoldberg requested a review from kanadgupta July 2, 2020 02:32
@erunion
Copy link
Member

erunion commented Jul 2, 2020

Not psyched about eval() but since it's just in customer markdown that's self-XSS territory if it gets abused.

@erunion erunion merged commit d2c95bc into master Jul 2, 2020
@erunion erunion deleted the fix/668/rdmd-compat-mode branch July 2, 2020 17:19
@rafegoldberg
Copy link
Contributor Author

@erunion strong agree, hence the decision to shove this in to compatibility mode, instead of running user scripts by default!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement A potential new feature to be added, or an improvement we could make
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDMD Compatibility Mode
2 participants