Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

fix: reverting date and date-time changes in #895 #950

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

erunion
Copy link
Member

@erunion erunion commented Sep 17, 2020

🧰 What's being changed?

This reverts the changes to date and date-time that were introduced in #895.

The datetime-local input isn't widely supported, and doesn't properly support datetimes so we're reverting and treating them, and date inputs, as simple strings for the indefinite future.

@erunion erunion added the type:bug Something isn't working label Sep 17, 2020
@erunion erunion requested a review from darrenyong September 17, 2020 18:59
Copy link
Contributor

@darrenyong darrenyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I actually understand what's happening 😂
Tested it in the API Explorer to make sure it's string type now!

Looks good to me!

@erunion erunion merged commit e4e1670 into next Sep 18, 2020
@erunion erunion deleted the revert/datetime-local-inputs branch September 18, 2020 03:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants