-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): moving unit tests over to vitest #691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for the most part, just a few small comments! very jealous of how easy of a drop-in replacement this was... readmeio/rdme#857 is looking rough 😬
"api": "file:../api", | ||
"fetch-mock": "^9.11.0", | ||
"isomorphic-fetch": "^3.0.0", | ||
"jest": "^29.6.1", | ||
"ts-jest": "^29.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love how we don't need any additional packages to support TS 😌
@@ -1,3 +1 @@ | |||
import 'jest-extended'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we really were living like gremlins huh
Co-authored-by: Kanad Gupta <8854718+kanadgupta@users.noreply.github.com>
Co-authored-by: Kanad Gupta <8854718+kanadgupta@users.noreply.github.com>
Co-authored-by: Kanad Gupta <8854718+kanadgupta@users.noreply.github.com>
Co-authored-by: Kanad Gupta <8854718+kanadgupta@users.noreply.github.com>
🧰 Changes
I've been wildy impressed with Vitest so this is moving us off Jest and over to that. The performance gains aren't going to break the bank, but I'll happily take a couple seconds off of the
api
suite any day.api
httpsnippet-client-api
⏭️ After
api
httpsnippet-client-api