Skip to content

fix: dont treat escapes as flow #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: dont treat escapes as flow #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions __tests__/migration/tables.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,4 +486,21 @@ ${JSON.stringify(
"
`);
});

it('compiles tables with leading escapes', () => {
const md = `
| Col 1 | Col 2 |
| --------- | ----- |
| \\_foo_\\ | bar |
`;

const mdx = migrate(md);

expect(mdx).toMatchInlineSnapshot(`
"| Col 1 | Col 2 |
| --------- | ----- |
| \\_foo\\_\\ | bar |
"
`);
});
});
10 changes: 2 additions & 8 deletions processor/migration/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@ import imagesTransformer from './images';
import linkReferenceTransformer from './linkReference';
import tableCellTransformer from './table-cell';

const transformers = [
emphasisTransformer,
imagesTransformer,
linkReferenceTransformer,
tableCellTransformer,
];

export default transformers
const transformers = [emphasisTransformer, imagesTransformer, linkReferenceTransformer, tableCellTransformer];

export default transformers;
2 changes: 1 addition & 1 deletion processor/transform/tables-to-jsx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const visitor = (table: Table, index: number, parent: Parents) => {
parent.children.splice(index, 1, { type: 'text', value: '\n' });
});

if (!phrasing(content)) {
if (!phrasing(content) && content.type !== 'escape') {
hasFlowContent = true;
return EXIT;
}
Expand Down
Loading