chore(deps): bump @readme/httpsnippet from 6.2.1 to 11.0.0 #1091 #1182
Conversation
Bumps [@readme/httpsnippet](https://github.com/readmeio/httpsnippet) from 6.2.1 to 11.0.0. - [Release notes](https://github.com/readmeio/httpsnippet/releases) - [Commits](readmeio/httpsnippet@6.2.1...11.0.0) --- updated-dependencies: - dependency-name: "@readme/httpsnippet" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "moduleResolution": "nodenext", | |||
There was a problem hiding this comment.
typescript will be changing the behavior of NodeNext in 5.8 so i'd recommend pinning it like so:
| "moduleResolution": "nodenext", | |
| "moduleResolution": "Node16", |
| "module": "nodenext", | ||
| "moduleResolution": "nodenext", |
There was a problem hiding this comment.
can we remove these lines? i believe this can be inferred from the tsconfig.build.json
| "module": "nodenext", | |
| "moduleResolution": "nodenext", |
There was a problem hiding this comment.
@domharrington @erunion any idea why we have two separate tsconfig files in this subpackage? any reason why we can't merge them?
There was a problem hiding this comment.
this package is so old, i have no idea.
|
@azinder1 were we still planning on moving this package into the monorepo? |
|
@erunion spoke with @azinder1 offline and here's the sequencing i'm imagining:
i think we can close this PR in favor of #1190 let me know what you think of all of this @gratcliff! |
|
i'm fine with that, but tbqh i don't think i'd bother with publishing a new release of that package. nobody but us should be using it as we're the only ones that get any value out of it. it also has dependents or published forks. |
🧰 Changes
Bumps @readme/httpsnippet from 6.2.1 to 11.0.0.
🧬 QA & Testing
Fixed failing tests