Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding a fastify demo #528

Merged
merged 3 commits into from
Aug 9, 2022
Merged

feat: adding a fastify demo #528

merged 3 commits into from
Aug 9, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 9, 2022

🚥 Fix RM-5073

🧰 Changes

  • Adds a new example codebase for how to use the SDK with Fastify.
  • Updates our Node SDK docs to mention the Hapi and this new Fastify examples.

🧬 QA & Testing

This is my first time using Fastify from a fresh, non-Metrics API start, so I'm not totally sure if everything I've done is the right way but requests came through:

Screen Shot 2022-08-09 at 4 30 07 PM

Screen Shot 2022-08-09 at 4 30 38 PM

Copy link
Member

@gratcliff gratcliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erunion!

@erunion erunion requested a review from gratcliff August 9, 2022 23:35
@erunion erunion merged commit ea92da3 into main Aug 9, 2022
@erunion erunion deleted the feat/fastify-usage branch August 9, 2022 23:40
Copy link
Member

@domharrington domharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #528 for a follow on from this adding it to the integration test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants