-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactoring allOf schemas to be pre-merged when we generate JSON Schema #579
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a41744b
chore: make our jsdoc eslint rules a bit less obnoxious
erunion 7ba7f2c
Merge branch 'main' into fix/pre-merge-allof-schemas
erunion b280b89
fix: refactoring allOf schemas to be merged when we generate JSON Schema
erunion 8503d59
chore: minor cleanup
erunion 4aba477
chore: reverting some unncessary changes
erunion fada777
fix: test snapshots
erunion 12ccbd6
fix: test snapshots
erunion 4927f9f
fix: removing an unnecessary logic block
erunion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| { | ||
| "openapi": "3.0.0", | ||
| "info": { | ||
| "title": "Polymorhism quirks", | ||
| "version": "1.0.0" | ||
| }, | ||
| "servers": [ | ||
| { | ||
| "url": "https://httpbin.org" | ||
| } | ||
| ], | ||
| "paths": { | ||
| "/allof-with-empty-object-property": { | ||
| "post": { | ||
| "description": "Within the allOf of this requestBody there is a `data` object property that has no schema.", | ||
| "requestBody": { | ||
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/components/schemas/api.WithdrawalRequest" | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "token": { | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/components/schemas/core.Token" | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "data": { | ||
| "$ref": "#/components/schemas/core.TokenData" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "required": true | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "components": { | ||
| "schemas": { | ||
| "api.WithdrawalRequest": { | ||
| "type": "object", | ||
| "required": [ | ||
| "amount", | ||
| "token", | ||
| "user" | ||
| ], | ||
| "properties": { | ||
| "amount": { | ||
| "type": "string" | ||
| }, | ||
| "token": { | ||
| "$ref": "#/components/schemas/core.Token" | ||
| }, | ||
| "user": { | ||
| "type": "string" | ||
| } | ||
| } | ||
| }, | ||
| "core.TokenData": { | ||
| "type": "object", | ||
| "properties": { | ||
| "decimals": { | ||
| "type": "integer", | ||
| "example": 18 | ||
| }, | ||
| "token_address": { | ||
| "type": "string" | ||
| }, | ||
| "token_id": { | ||
| "type": "string", | ||
| "example": "200" | ||
| } | ||
| } | ||
| }, | ||
| "core.Token": { | ||
| "type": "object", | ||
| "properties": { | ||
| "data": {}, | ||
| "type": { | ||
| "type": "string" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these because they were always going to be merged into a single
titleproperty.