feat: addition of a getRequestBody accessor #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
force-pushed
the
feat/getrequestbody-accessor
branch
from
4e8e4bf to
ab86b89
Compare
erunion
commented
Jan 12, 2022
| describe('#getResponseByStatusCode()', () => { | ||
| it('should return false if the status code doesnt exist', () => { | ||
| const operation = Oas.init(petstore).operation('/pet/findByStatus', 'get'); | ||
| expect(operation.getResponseByStatusCode(202)).toBe(false); | ||
| }); | ||
|
|
||
| it('should return the response', () => { | ||
| const operation = Oas.init(petstore).operation('/pet/findByStatus', 'get'); | ||
| it('should return the response', async () => { |
There was a problem hiding this comment.
I had to rework this test a bit because the dereferencing library we use does parameter reassigning so if one test dereferences the petstore spec then tests that use that spec after it will have a dereferenced spec.
erunion
requested review from
a team,
Dashron and
julshotal
and removed request for
a team
Dashron
approved these changes
Jan 12, 2022
| } | ||
|
|
||
| const requestBody = this.schema.requestBody; | ||
| if (RMOAS.isRef(requestBody) || !(mediaType in requestBody.content)) { |
There was a problem hiding this comment.
Why return false if it's a ref? It's probably worth leaving those details as a comment here. I also don't see any tests for when the req body is a ref.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Adds a new
getRequestBodyaccessor on theOperationobject that pulls back a request body Media Type Object for any specific media type that's present on the operation.This isn't going to be used anywhere just yet but when we refactor/rewrite the
getSchema()library here it can be used there.🧬 QA & Testing
See tests.