fix: issue where a securityScheme may be corrupted with internal library data #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
requested review from
a team,
Dashron,
julshotal and
emilyskuo
and removed request for
a team
julshotal
approved these changes
Mar 23, 2022
julshotal
approved these changes
Mar 24, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This resolves an issue I discovered while working on readmeio/api#422 where if you called
operation.prepareSecurity()and then ran OAS validation against the spec you ingested intooasvalidation would fail becauseoperation.prepareSecurity()would append our internal security scheme name tracking information to a_keyproperty.Tests never caught this because they were asserting directly against the corrupted spec data. 🙃