fix: bug where request example selection wouldn't always use the first #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
requested review from
a team,
Dashron,
julshotal and
kanadgupta
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This is a weird one! Right now if you have a request body that utilizes
examplesand have multiple examples within that ourexampledetermination forOperation.getParametersToJSONSchema()will now will pick an example from each down the list as it processes property.For example:
Reason this is happening is because the
schema.examplesarray we're working with inlib/openapi-to-json-schemais a reference and when we run.shift()on it we effectively remove that example from being used for the next property we're processing JSON Schema for.🫠