refactor: migrate oas libraries of ours into this new monorepo #811
Conversation
erunion
added
enhancement
|
|
||
| [](https://github.com/readmeio/oas/tree/main/packages/oas-extensions) | ||
|
|
||
| [](https://readme.io) |
There was a problem hiding this comment.
yeah i was sick of seeing that cloudfront.net link
There was a problem hiding this comment.
I have an open design request to update this and i was literally thinking of doing this so we can just update the graphic in one fell swoop
packages/oas/.npmignore
Outdated
There was a problem hiding this comment.
since we're specifying files via that files array in the package.json, we might not need a lot of this but that can happen in a separate PR.
packages/oas-to-har/tsup.config.ts
Outdated
There was a problem hiding this comment.
would love to make a shared tsup config at the top level (but again, can happen in a separate PR)
.github/workflows/ci.yml
Outdated
| @@ -31,4 +31,16 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - run: npm ci | |||
|
|
|||
| # With the way these libraries use each other we need to run our build step for linting in a | |||
There was a problem hiding this comment.
i think it'd be safer to configure stuff like this via lerna, that way we can run a top-level npm run build command. i think something like this? https://lerna.js.org/docs/concepts/task-pipeline-configuration#define-task-dependencies-aka-task-pipelines
There was a problem hiding this comment.
It only seems like we're able to say "run before " but only on a global level. I don't see any way with Lerna/NX to set up something that says "run oas-normalize build before oas build`.
There was a problem hiding this comment.
i might play around with turborepo at some point: https://turbo.build/repo/docs/core-concepts/monorepos/task-dependencies
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else if (typeof obj === 'object') { | ||
| return 'json'; | ||
| } else if (typeof obj === 'string') { | ||
| if (obj.match(/\s*{/)) { |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
* refactor: remove pretest scripts that way we're not double linting * refactor: build using lerna * chore: oops
🧰 Changes
This migrates the following libraries into the new monorepo structure that I've started with #810:
Others that may be moved later: