Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oas): export and reuse Variables type #897

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Sep 4, 2024

🧰 Changes

Noticed some type discrepancies in how we describe server variables — this PR fixes that.

🧬 QA & Testing

Do tests pass?

@kanadgupta kanadgupta added bug Something isn't working refactor Issues about tackling technical debt labels Sep 4, 2024
@kanadgupta kanadgupta marked this pull request as ready for review September 4, 2024 01:39
packages/oas/src/index.ts Outdated Show resolved Hide resolved
@kanadgupta kanadgupta merged commit 95423ff into main Sep 4, 2024
6 checks passed
@kanadgupta kanadgupta deleted the kanad-2024-09-03/variable-type-improvements branch September 4, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants