Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrading path-to-regexp #902

Merged
merged 2 commits into from
Sep 10, 2024
Merged

chore(deps): upgrading path-to-regexp #902

merged 2 commits into from
Sep 10, 2024

Conversation

erunion
Copy link
Member

@erunion erunion commented Sep 10, 2024 •
edited
Loading

🚥 Resolves #901

🧰 Changes

path-to-regexp@7 has a vulnerability regarding backtick expressions GHSA-9wv6-86v2-598j so we need to upgrade it.

  • Swaps out fetch-mock in oas-normalize for nock. fetch-mock was using a very old version of path-to-regexp
  • Upgrades path-to-regexp in oas.
    • Unfortunately they've changed the the MatchResult interface we use to no longer return index so this may need to be treated as a breaking change as we have returned that value on .findOperation() and .findOperationWithoutMethod().

@erunion erunion added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 10, 2024
@erunion erunion requested review from a team, kanadgupta and darrenyong and removed request for a team September 10, 2024 18:02
@erunion erunion mentioned this pull request Sep 10, 2024
Closed
kanadgupta
kanadgupta approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao i was literally about to DM you about this ⚡

@erunion erunion merged commit df44f04 into main Sep 10, 2024
9 checks passed
@erunion erunion deleted the chore/bump-path-to-regexp branch September 10, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanadgupta kanadgupta kanadgupta approved these changes

@darrenyong darrenyong Awaiting requested review from darrenyong darrenyong was automatically assigned from readmeio/api-tooling

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability path-to-regexp
2 participants
@erunion @kanadgupta