fix: correctly handle nullable: false
#915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Currently, if a schema has
nullable: false
, (idk why since it defaults to false? maybe some tooling explicitly defines it as such) we aren't properly handling it as we're only checking for the existence of anullable
property.I added a condition to only add the
null
type ifnullable: true
. If it'sfalse
, we don't want to do anything with it, but we still want to delete it so it doesn't show up in the schema. Added a test too.🧬 QA & Testing
Provide as much information as you can on how to test what you've done.