Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle nullable: false #915

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

darrenyong
Copy link
Contributor

🚥 Resolves RM-11473

🧰 Changes

Currently, if a schema has nullable: false, (idk why since it defaults to false? maybe some tooling explicitly defines it as such) we aren't properly handling it as we're only checking for the existence of a nullable property.

I added a condition to only add the null type if nullable: true. If it's false, we don't want to do anything with it, but we still want to delete it so it doesn't show up in the schema. Added a test too.

🧬 QA & Testing

Provide as much information as you can on how to test what you've done.

Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmk when you want to publish this and i can handle it for ya

@darrenyong darrenyong merged commit 927ed2d into main Nov 20, 2024
7 checks passed
@darrenyong darrenyong deleted the darren/support-nullable-false branch November 20, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants