Skip to content

Commit

Permalink
ci: add test for validation failures (#1102)
Browse files Browse the repository at this point in the history
## 🧰 Changes

Adding a test so we can easily see errors when they're thrown in GitHub
Actions. Also added a few related assertion steps.

## 🧬 QA & Testing

Does the validation error show up properly? And do tests pass?
  • Loading branch information
kanadgupta authored Dec 4, 2024
1 parent 4db0f58 commit 95cc2a9
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,21 @@ jobs:
with:
rdme: openapi:validate "oas-examples-repo/3.1/json/petstore.json"

- name: Run `openapi:validate` on an invalid file
uses: ./rdme-repo/
id: openapi-validate-fail
continue-on-error: true
with:
rdme: openapi:validate rdme-repo/__tests__/__fixtures__/invalid-oas.json

- name: Assert that previous validation step failed
if: ${{ steps.openapi-validate-fail.outcome == 'failure' }}
run: echo "The validation in the previous step failed as expected."

- name: Throw error if previous validation step did not fail
if: ${{ steps.openapi-validate-fail.outcome == 'success' }}
run: echo "::error::Expected validation in previous step to fail" && exit 1

# Docs: https://rdme-test.readme.io
- name: Run `openapi` command
uses: ./rdme-repo/
Expand Down

0 comments on commit 95cc2a9

Please sign in to comment.