-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove openapi
v1 command
#1111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
refactor
Issues about tackling technical debt
command:openapi
Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands
labels
Dec 6, 2024
erunion
approved these changes
Dec 11, 2024
kanadgupta
added a commit
that referenced
this pull request
Dec 12, 2024
## 🧰 Changes this PR aggregates all of the PRs going out as part of the v10 release (i.e, the second section of PRs below). all PRs should be reviewed prior to being merged into this branch. ### outstanding tasks #### needs to go out _before_ v10 is released (i.e., in the v9 release channel) - [x] #1082 #### needs to go out as part of v10 release - [x] `openapi upload` - [x] #1111 - [x] #1116 - [x] #1107 - [x] #1104 - [x] #1108 #### merge into `v9` branch once `v10` release is successfully released - [ ] #1121 #### double-check these things before merging - [x] swap out any links to the `v9` docs (e.g., `/tree/v9`) with `v10` as needed (b19416d) - [x] make sure all API v1 requests in `v10` will work - [x] make sure v10 migration guide reflects the final design decisions around `openapi upload` ##⚠️ Breaking Changes <sub>listing all of the breaking changes 1 by 1 below so they get picked up by semantic release...</sub> BREAKING CHANGE: `categories`, `custompages`, `docs` and `versions` have now been removed. Please use a bidirectional syncing workflow instead. Read more in [our migration guide](https://github.com/readmeio/rdme/tree/v10/documentation/migration-guide.md). BREAKING CHANGE: `rdme openapi` has been replaced by `rdme openapi upload`. Read more in [our migration guide](https://github.com/readmeio/rdme/tree/v10/documentation/migration-guide.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
command:openapi
Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands
refactor
Issues about tackling technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Removes the
openapi
command in its current form. Will be replaced byopenapi upload
(see #1116!)Will be merging this PR into #1113 to collect all breaking changes as part of this PR!
🧬 QA & Testing
Provide as much information as you can on how to test what you've done.
BREAKING CHANGE:
rdme openapi
has been removed. Please userdme openapi upload
instead. Read more in our migration guide.