Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quieter log outputs when installing GHA #566

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Aug 10, 2022

🧰 Changes

As part of #560, we added a build step when setting up the GitHub Actions environment. But this in turn made the logs a bit noisy:

image

This makes a small update to our Actions workflow so we're not outputting tsc build logs that the user doesn't need to know about:

Screen Shot 2022-08-10 at 4 32 49 PM

I also added --no-save to our npm install step since there's no point in updating the lockfile. Not sure if it's faster to do this vs. npm ci. At some point it might be cool to look into caching our dependencies but this seems okay for now.

🧬 QA & Testing

Do the GitHub Action dry runs continue to run as expected? And do the logs look cleaner?

@kanadgupta kanadgupta added the enhancement New feature or request label Aug 10, 2022
@kanadgupta kanadgupta marked this pull request as ready for review August 10, 2022 21:36
@kanadgupta kanadgupta requested a review from erunion August 10, 2022 21:36
action.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants