feat: add testing-library plugins to testing config #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Was concerned about pulling these into the general testing config that it would throw false positives on tests that don't do UI testing, but I pulled this branch into https://github.com/readmeio/fetch-har and it didn't so LGTM.
|
Good to hear! I didn't do any testing myself, but these plugins appear to be tied to specific testing packages so I'm hoping it won't cause any issues 🤞🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these two plugins:
I was thinking of making this a separate
ui-testing.jsfile, but changed my mind because it felt like it'd be annoying to have two different places to manage our Jest rules. Totally open to discussion on this.