Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filtering empty lines in docblocks preventing markdown tables from working #275

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 23, 2022

🧰 Changes

This removes some unnecessary empty line filtering that's going on when we're composing endpoints that's causing issues if a user attempts to compose a Markdown table in an endpoint description.

🧬 QA & Testing

See tests.

@erunion erunion added the bug Something isn't working label Aug 23, 2022
@erunion erunion requested a review from jcappello August 23, 2022 20:49
Copy link

@jcappello jcappello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good to me!

@erunion erunion merged commit 3fbc42b into main Aug 23, 2022
@erunion erunion deleted the fix/markdown-tables branch August 23, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants