Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docdiff: integrate nicely #23

Closed
humitos opened this issue Mar 28, 2023 · 0 comments · Fixed by #63
Closed

Docdiff: integrate nicely #23

humitos opened this issue Mar 28, 2023 · 0 comments · Fixed by #63

Comments

@humitos
Copy link
Member

humitos commented Mar 28, 2023

Description in progress (I'll be editing it)

How do we want to integrate with docdiff?

  • enable by default on PRs
  • ability disable and re-enable by the reader
  • as a reader, how I can decide how to diff? show only additions, show only removals, both?
  • etc

References: https://github.com/readthedocs/meta/discussions/38
@humitos humitos mentioned this issue Apr 27, 2023
Merged
@humitos humitos mentioned this issue May 23, 2023
Closed
@humitos humitos mentioned this issue Aug 28, 2023
Closed
humitos added a commit that referenced this issue Aug 31, 2023
@humitos
Docdiff: initial work to toggle enabled/disabled (#63)
32a0449 
![Peek 2023-04-25
16-43](https://user-images.githubusercontent.com/244656/234422680-79c4562a-f2d0-475d-b8a7-a76757ef514b.gif)


Closes #62 
Closes #23 
Closes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
✨ Addons
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docdiff: initial work to toggle enabled/disabled readthedocs/addons
1 participant
@humitos