Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: trigger the modal with a modifier (e.g. Ctrl + K) #57

Closed
humitos opened this issue Apr 20, 2023 · 2 comments
Closed

Search: trigger the modal with a modifier (e.g. Ctrl + K) #57

humitos opened this issue Apr 20, 2023 · 2 comments

Comments

@humitos
Copy link
Member

humitos commented Apr 20, 2023

In #56 we implemented a way to change the key used to show the modal. However, it does not allow to define a modifier like Ctrl, Shift or Meta. It would be good to add another attribute show-modal-modifier to specify this.

@humitos
Copy link
Member Author

humitos commented Apr 27, 2023

Take a look at this comment, #58 (comment)

@humitos
Copy link
Member Author

humitos commented Sep 12, 2023

This can now be done with the hotkeys addon by defining the API response as Ctrl + k 😉

The question about if it's useful to make this configurable via HTML attributes still remains, tho: #43 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant