HTML attributes API: configure the addon via HTML attributes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the search modal is shown when pressing `/`. However, we want this to be configurable by the user. This can be achieved by passing `show-modal-keycode` attribute to the web component as follows: ```html <readthedocs-search show-modal-keycode="220"> </readthedocs-search> ``` In this case, it will be shown when pressing `\`. I think this is a good pattern for static values that won't be changed from the dashboard or similar in a dynamic way. Related #13
agjohnson
reviewed
Apr 19, 2023
|
Thanks for the feedback. I updated the code to use Lit properties. |
agjohnson
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the search modal is shown when pressing
/. However, we want this to be configurable by the user. This can be achieved by passingshow-modal-keycodeattribute to the web component as follows:In this case, it will be shown when pressing
\.I think this is a good pattern for static values that won't be changed from the dashboard or similar in a dynamic way.
Related #13