Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: simplify and standardize data usage #281

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 26, 2024

Implements the changes in the API made in readthedocs/readthedocs.org#11205. We need to merge that PR and deploy addons together with the changes in this PR.

In this PR there are mainly no changes in the logic. The most important thing to mention here is that we are standardizing the usage of the API response and pinning to v1 now (we were using v0-alpha). This means:

I'm not sure there are too much to review here, but I'd appreciate at least a quick look at these changes. I'm happy to answer some questions you may have here or on the underlying PR about the API response changes.

Related:

@humitos humitos marked this pull request as ready for review April 8, 2024 13:44
@humitos humitos requested a review from a team as a code owner April 8, 2024 13:44
@humitos humitos requested a review from agjohnson April 8, 2024 13:44
It does not include itself in the response.
@humitos humitos self-assigned this Apr 8, 2024
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I didn't spend too much time looking through the schemas, but trust our tests would pick up issues there anyways.

@humitos
Copy link
Member Author

humitos commented Apr 10, 2024

but trust our tests would pick up issues there anyways.

I can confirm this. I took me a lot of time to adapt them to the new schema 😅

humitos and others added 2 commits April 11, 2024 13:48
Co-authored-by: Anthony <aj@ohess.org>
@humitos humitos merged commit cb57a67 into main Apr 11, 2024
4 checks passed
@humitos humitos deleted the humitos/api-restructure branch April 11, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Notification: handle stable/latest aliases
2 participants