Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Miniconda3 #109

Closed
wants to merge 1 commit into from
Closed

Use Miniconda3 #109

wants to merge 1 commit into from

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 18, 2019

Update to use Miniconda3 considering that Python2 is about to die in a
couple of months.

The only change from a user perspective is that will make people not
defining the Python version in their environment.yml file to default
on Python 3.

Closes #86

Update to use Miniconda3 considering that Python2 is about to die in a
couple of months.

The only change from a user perspective is that, will make people not
defining the Python version in their `environment.yml` file to default
on Python 3.
@humitos humitos requested a review from a team July 18, 2019 11:06
@agjohnson
Copy link
Contributor

Forcing the version of Python we call was a little easier, because we had control of the config file. Because we don't have direct control over the environment.yml file, this change seems like it would pretty immediately break builds. Is there a softer way of doing this?

@humitos
Copy link
Member Author

humitos commented Jul 23, 2019

@agjohnson I think using Miniconda3 is the right approach, so we stay tunned with the community.

My idea to not break old projects not setting the - python== version on their environment.yaml is to add a timed feature flag and append - python==2.7 to it. Using the same/similar code than in readthedocs/readthedocs.org#5956

@humitos
Copy link
Member Author

humitos commented Jul 23, 2019

Here, https://github.com/readthedocs/readthedocs.org/pull/5956/files#diff-31f8391d8643c47c6caedf53930c0b7eR530, _get_core_requirements could also include python==2.7 if the flag is enabled and everything will keep working.

@humitos
Copy link
Member Author

humitos commented Mar 24, 2020

It seems that Python2 will be supported forever. So, I'm closing this.

@humitos humitos closed this Mar 24, 2020
@humitos humitos deleted the humitos/default-to-miniconda3 branch June 17, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to py3 for new conda projects
2 participants