Lint cleanup

readthedocs/integrations/admin.py

@@ -1,12 +1,8 @@
 """Integration admin models"""
 
-from datetime import datetime, timedelta
-
 from django.contrib import admin
-from django.contrib.contenttypes.models import ContentType
 from django.core import urlresolvers
 from django.utils.safestring import mark_safe
-from django.utils.translation import ugettext_lazy as _
 from pygments.formatters import HtmlFormatter
 
 from .models import Integration, HttpExchange
@@ -16,7 +12,7 @@ def pretty_json_field(field, description, include_styles=False):
     # There is some styling here because this is easier than reworking how the
     # admin is getting stylesheets. We only need minimal styles here, and there
     # isn't much user impact to these styles as well.
-    def inner(self, obj):
+    def inner(_, obj):
         styles = ''
         if include_styles:
             formatter = HtmlFormatter(style='colorful')
@@ -33,6 +29,11 @@ def inner(self, obj):
 
 class HttpExchangeAdmin(admin.ModelAdmin):
 
+    """Admin model for HttpExchange
+
+    This adds some read-only display to the admin model.
+    """
+
     readonly_fields = [
         'date',
         'status_code',
@@ -76,6 +77,12 @@ def failed_icon(self, obj):
 
 class IntegrationAdmin(admin.ModelAdmin):
 
+    """Admin model for Integration
+
+    Because of some problems using JSONField with admin model inlines, this
+    instead just links to the queryset.
+    """
+
     search_fields = ('project__slug', 'project__name')
     readonly_fields = ['exchanges']
 
@@ -86,8 +93,8 @@ def exchanges(self, obj):
         just to link to the exchanges.
         """
         url = urlresolvers.reverse('admin:{0}_{1}_changelist'.format(
-            HttpExchange._meta.app_label,
-            HttpExchange._meta.model_name,
+            HttpExchange._meta.app_label,  # pylint: disable=protected-access
+            HttpExchange._meta.model_name,  # pylint: disable=protected-access
         ))
         return mark_safe('<a href="{0}?{1}={2}">{3} HTTP transactions</a>'.format(
             url,

readthedocs/integrations/models.py

@@ -93,8 +93,8 @@ def delete_limit(self, related_object, limit=10):
         else:
             queryset = self.filter(
                 content_type=ContentType.objects.get(
-                    app_label=related_object._meta.app_label,
-                    model=related_object._meta.model_name,
+                    app_label=related_object._meta.app_label,  # pylint: disable=protected-access
+                    model=related_object._meta.model_name,  # pylint: disable=protected-access
                 ),
                 object_id=related_object.pk
             )