Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable builds are triggered recursively #4980

Closed
humitos opened this issue Dec 10, 2018 · 0 comments
Closed

Stable builds are triggered recursively #4980

humitos opened this issue Dec 10, 2018 · 0 comments
Labels
Accepted Accepted issue on our roadmap Bug A bug
Milestone
Build stability

Comments

@humitos
Copy link
Member

humitos commented Dec 10, 2018 •
edited
Loading

On Sunday we found that a build for the stable version was triggered constantly (Example, http://readthedocs.org/projects/bugzilla/builds/)

@ericholscher hotfixed this with this commit 83caf8fe8 to avoid the "Sunday problem", but we need to research and fix it properly.

We suspect that this could be introduced on #4433 and/or #4876.
@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Dec 10, 2018
@humitos humitos added this to the Build stability milestone Dec 10, 2018
ericholscher added a commit that referenced this issue Dec 10, 2018
@ericholscher
Only use remote branches for our syncing.
9257b34 
We don't care about branches local to us.
This causes bugs where a local and remote branch have the same name,
and we sync `stable` in and endless loop.

Fixes #4980
@ericholscher ericholscher mentioned this issue Dec 10, 2018
Merged
ericholscher added a commit that referenced this issue Dec 10, 2018
@ericholscher
Only use remote branches for our syncing.
435023d 
We don't care about branches local to us.
This causes bugs where a local and remote branch have the same name,
and we sync `stable` in and endless loop.

Fixes #4980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Milestone
Build stability
Development

No branches or pull requests
1 participant
@humitos