You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently are saving the whole path, including the root of the servers, that info isn't useful for us or for the user later. We will not lose any kind of information, because we already have the base path to validate files. This shouldn't be a big refactor, and we have a lot of tests.
I saw that we are using absolute path in other places, not just in this config module. For example, on the build output page --which generate to scroll horizontally to know the command executed.
Do you think it worth to consider to user relative path in other places also? What are your thoughts on this?
Do you think it worth to consider to user relative path in other places also? What are your thoughts on this?
Yeah, when I refactored the code, I tried to put most of the commands with relative paths (like requirements, conda env, etc).
We still depend on absolute paths to set the cache to pip, virtualenv root, python binnary.
We can remove some of those using env variables, after all, isn't helpfull at all for the user to know where we are saving the cache/virtualenv. This is another issue, not in the scope of this one.
stsewd
added a commit
to stsewd/readthedocs.org
that referenced
this issue
Mar 1, 2019
We currently are saving the whole path, including the root of the servers, that info isn't useful for us or for the user later. We will not lose any kind of information, because we already have the base path to validate files. This shouldn't be a big refactor, and we have a lot of tests.
Ref #4863 (comment)
The text was updated successfully, but these errors were encountered: