Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad link to fabfile.py in Internationalization page in documentation #6525

Closed
rffontenelle opened this issue Jan 15, 2020 · 11 comments · Fixed by #6531
Closed

Bad link to fabfile.py in Internationalization page in documentation #6525

rffontenelle opened this issue Jan 15, 2020 · 11 comments · Fixed by #6531
Labels
Good First Issue Good for new contributors Needed: documentation Documentation is required

Comments

@rffontenelle
Copy link
Contributor

Details

Expected Result

Clicking "fabric script" hyperlink should get to such script in the URL https://github.com/readthedocs/readthedocs.org/blob/master/fabfile.py

Actual Result

Clicking such hyperlink results in 404 not found, as the script is not in the root directory of readthedocs repository

@stsewd
Copy link
Member

stsewd commented Jan 15, 2020

We us invoke with a tasks.py file now https://github.com/readthedocs/readthedocs.org/blob/master/tasks.py.

@stsewd stsewd added Good First Issue Good for new contributors Needed: documentation Documentation is required labels Jan 15, 2020
@rffontenelle
Copy link
Contributor Author

rffontenelle commented Jan 15, 2020

@stsewd Would you say it is enough to simply replace the URL then?

EDIT: The sentence is For the Read the Docs community site, we use a fabric script to follow this process

@stsewd
Copy link
Member

stsewd commented Jan 15, 2020

Yeah, the paragraph and url should be updated.

@preetmishra
Copy link
Contributor

@stsewd Can I work on this?

@rffontenelle
Copy link
Contributor Author

@preetmishra Hey, feel free to provide a pull request to solve this.

@susanka068
Copy link

Is the isuue still open ?
then I'd like to work on this .

@rffontenelle
Copy link
Contributor Author

@susanka068 I seems @preetmishra wants to work on this, but check with him.

@susanka068
Copy link

susanka068 commented Jan 16, 2020

@susanka068
Copy link

fixed this issue #6532 @rffontenelle

@stsewd
Copy link
Member

stsewd commented Jan 17, 2020

@susanka068 you need to update the paragraph too.

@preetmishra
Copy link
Contributor

preetmishra commented Jan 17, 2020

@susanka068 Hey, make sure no one else is working on an issue before taking it so that you don't up working on the same thing when you could've worked on another issue. I have already attached a PR.
@rffontenelle @stsewd Can you please review it? #6531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for new contributors Needed: documentation Documentation is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants