Canonical redirects: check if the project supports custom domains #10098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In .com need to check for this. But we don't allow users to create custom domains if they don't have the right subscription, so not sure if this is really needed.. It can be useful only if a user downgrades their subscription I guess.
humitos
reviewed
Mar 2, 2023
Member
humitos
left a comment
humitos
left a comment
There was a problem hiding this comment.
I think this looks good from the backend perspective. However, we should have some better UX here as well. That is,
- if the user wants to downgrade, we should alarm they about this
- if they stop paying us for some reason, their whole site will fail immediately -- not good
- something else to think about?
That said, have you thought about these things already and how we can handle?
Member
Author
Their site will keep working, this change matches the current behavior, we just stop redirecting to their canonical domain if users visit their docs to a non-canonical domain. |
Member
Author
I think downgrading happens in the stripe UI, not sure what stripe shows there currently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .com need to check for this.
But we don't allow users to create custom domains if they don't have the right subscription, so not sure if this is really needed.. It can be useful only if a user downgrades their subscription I guess.