-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: don't override get_available_name
(Django Storages)
#11505
base: main
Are you sure you want to change the base?
Conversation
The fuction `get_available_overwrite_name` was removed. There is a setting `file_overwrite` which is set to `True` by default and our override shouldn't be required anymore. https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.html#settings Related: #11502
@stsewd does this change look good for you? |
Makes sense. Tests are broken. |
It seems that it's not overriding the files but adding a suffix:
In theory, it should behave like that by default in the newer version, but 🤷🏼 |
OK, it's seems the problem here is a combination of things between django-storages and Django itself. There is a long conversation at jschneier/django-storages#1430. I will block this PR for now and keep an eye on that conversation for now. |
The fuction
get_available_overwrite_name
was removed. There is a settingfile_overwrite
which is set toTrue
by default and our override shouldn't be required anymore.https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.html#settings
Related: #11502