Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of supported tools #11547

Merged
merged 32 commits into from
Sep 23, 2024
Merged

Add list of supported tools #11547

merged 32 commits into from
Sep 23, 2024

Conversation

plaindocs
Copy link
Contributor

@plaindocs plaindocs commented Aug 15, 2024

And also addon config for each one.

Fixes #11187

Still to do:

  • delete Getting started with * content
  • redirect user/intro/getting-started-with-mkdocs.rst -> user/intro/mkdocs
  • redirect user/intro/getting-started-with-sphinx.rst -> user/intro/sphinx
  • figure out example repos
  • revert dependencies

Open questions:


📚 Documentation previews 📚

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going in the correct direction.

I left a suggestion about the section structure for the addons that I think it works better.

Apart from that, there are just other small suggestions to link to external and internal pages.

Let me know if you have any particular doubt where I can be useful.

docs/user/guides/canonical-urls.rst Outdated Show resolved Hide resolved
docs/user/intro/doctools.rst Outdated Show resolved Hide resolved
docs/user/intro/doctools.rst Outdated Show resolved Hide resolved
docs/user/intro/mkdocs.rst Outdated Show resolved Hide resolved
docs/user/intro/mkdocs.rst Outdated Show resolved Hide resolved
docs/user/intro/mkdocs.rst Outdated Show resolved Hide resolved
docs/user/intro/mkdocs.rst Outdated Show resolved Hide resolved
docs/user/intro/mkdocs.rst Outdated Show resolved Hide resolved
docs/user/intro/mkdocs.rst Outdated Show resolved Hide resolved
@plaindocs
Copy link
Contributor Author

@humitos how general is the advice to pin your Sphinx version? Should we be recommending this for all doctools?

   We strongly recommend to :doc:`pin the Sphinx version </guides/reproducible-builds>`
   used for your project to build the docs to avoid potential future incompatibilities.

@humitos
Copy link
Member

humitos commented Sep 2, 2024

@humitos how general is the advice to pin your Sphinx version? Should we be recommending this for all doctools?

It's good advice. However, I don't think we need to cover this into these introduction pages. It will deviate the attention to a completely different and deep hole.

docs/user/intro/sphinx.rst Outdated Show resolved Hide resolved
docs/user/intro/sphinx.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subpage structure seems plenty good, we can always build out more content on the listing page later but I did note it for now.

docs/user/intro/doctools.rst Outdated Show resolved Hide resolved
docs/user/intro/doctools.rst Outdated Show resolved Hide resolved
docs/user/intro/doctools.rst Show resolved Hide resolved
@plaindocs
Copy link
Contributor Author

I can easily revert c7216e9 if we'd prefer a different approach.

@plaindocs
Copy link
Contributor Author

At a guess I need to do the pip-compile --output-file=requirements/docs.txt requirements/docs.in when adding dependencies to docs.in?

@humitos
Copy link
Member

humitos commented Sep 6, 2024

At a guess I need to do the pip-compile --output-file=requirements/docs.txt requirements/docs.in when adding dependencies to docs.in?

Yes 😄

@plaindocs plaindocs marked this pull request as ready for review September 19, 2024 16:02
@plaindocs plaindocs requested review from a team as code owners September 19, 2024 16:02
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm happy to merge it so we have something to link our users to. We can make iterative changes if needed.

docs/user/intro/mkdocs.rst Outdated Show resolved Hide resolved
docs/user/intro/sphinx.rst Outdated Show resolved Hide resolved
Comment on lines 104 to 118
Integrate the Read the Docs version menu into your site navigation
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If you're using the `Read the Docs Sphinx Theme <https://sphinx-rtd-theme.readthedocs.io/en/stable/>`__, the :ref:`flyout-menu:Addons flyout menu` is already fully integrated.

You *may* need to set `flyout_display` to `hidden <https://sphinx-rtd-theme.readthedocs.io/en/latest/configuring.html#confval-flyout_display>`_ in your ``conf.py`` so as not to display two identical menus:

.. code-block:: py
:caption: conf.py

html_theme_options = {
"flyout_display": "hidden",
}

If you're using a different theme, the flyout menu will display in the default bottom right side of your docs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've change how this works now implementing the version/language selectors and that's what we want people to use for now. They are enabled by default, so we should remove this section since it's not valid anymore.

The new version of the theme hides the integrated flyout by default. If the user want to enable it, they have to define flyout_display: "attached". If we want to keep this section, we could communicate that instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and commented this section for now in eb71007; but we need to revisit this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @humitos , let me see if I've got this right:

  • version / language selectors are enabled by default (are they different from the new flyout?) - are they configurable?
  • The flyout is hidden by default, to show it use flyout_display: "attached"

Copy link
Member

@humitos humitos Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version / language selectors are enabled by default?

Yes, only on our own theme, tho.

image

(are they different from the new flyout?)?

Yes and no. They use the exact same data (same versions, languages, etc). However, the version/language selectors shown in the top left nav bar are managed by the theme itself.

On the other hand, the new flyout is automatically injected by Read the Docs and is shown floating a the bottom.

image

are they configurable?

The version/language selectors are not configurable. The flyout is configurable via the Addons' settings in the dashboard.

--> actually they are configurable by the theme?

The flyout is hidden by default, to show it use flyout_display: "attached"

No. The new flyout (the one that Read the Docs injects) is shown by default (together with the version/language selectors from the theme).

If flyout_display is defined as attached in the theme options, the "integrated flyout" will be shown in at the bottom of the navbar. However, this does nothing on the new Read the Docs Addons flyout. At this point, both flyout will be shown.

The Read the Docs Addons flyout can be disabled from the Addons' settings in the dashboard.


Does this make sense?

--> only kinda at the moment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to poke at things and see if it does :-D

docs/user/intro/sphinx.rst Outdated Show resolved Hide resolved
@humitos
Copy link
Member

humitos commented Sep 23, 2024

we probably need to address the distinction between people using mkdocs in the RTD config, and people using mkdocs in build commands on this page

What is this distinction you refer to here?

@humitos
Copy link
Member

humitos commented Sep 23, 2024

I made some small changes to this PR so we can merge it now and making it part of tomorrow's release. However, there are a few things to work on still. I want to make those changes in an iterative way so we can start linking this content to users and testing how it performs.

@humitos humitos enabled auto-merge (squash) September 23, 2024 10:29
@humitos humitos merged commit 4043094 into main Sep 23, 2024
5 checks passed
@humitos humitos deleted the sam/doctools branch September 23, 2024 10:34
@plaindocs
Copy link
Contributor Author

we probably need to address the distinction between people using mkdocs in the RTD config, and people using mkdocs in build commands on this page

What is this distinction you refer to here?

So you could (in theory) build mkdocs docs like https://docs.readthedocs.io/en/stable/config-file/v2.html#build-commands or with https://docs.readthedocs.io/en/stable/config-file/v2.html#mkdocs right?

But would there be any config difference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: create a page per doctool supported
3 participants