Remove disable_sphinx_manipulation feature flag #11841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Dec 11, 2024
readthedocs/doc_builder/base.py
Outdated
| @@ -40,7 +40,7 @@ def get_final_doctype(self): | |||
| """Some builders may have a different doctype at build time.""" | |||
| return self.config.doctype | |||
|
|
|||
| def append_conf(self): | |||
| def show_conf(self): | |||
| """Set custom configurations for this builder.""" | |||
There was a problem hiding this comment.
Suggested change
| """Set custom configurations for this builder.""" | |
| """Show custom configurations for this builder.""" |
Comment on lines
+198
to
+199
| # Mark this version to inject the new js client when serving it via El Proxito. | ||
| self.data.version.addons = True |
There was a problem hiding this comment.
We can delete the field Version.addons now. We are not using it anymore since we are always inject addons unless AddonsConfig.enabled=False -- but we are not checking for Version.addons.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is enabled by default on .org and .com, so the other branches are dead code now.
append_confwas renamed toshow_confsince that's what it only does.